On 09/11/2012 07:02 AM, Thierry Reding wrote: > On Mon, Sep 10, 2012 at 11:51:48PM +0200, Lars-Peter Clausen wrote: >> On 09/10/2012 02:05 PM, Thierry Reding wrote: >>> This commit moves the driver to drivers/pwm and converts it to the new >>> PWM framework. >>> >>> Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx> >> >> Seems to work, thanks a lot. This one and patch 2: >> >> Acked-by: Lars-Peter Clausen <lars@xxxxxxxxxx> >> Tested-by: Lars-Peter Clausen <lars@xxxxxxxxxx> >> >> But I noticed a different problem. Some drivers using the pwm API depend on >> HAVE_PWM (e.g. the pwm beeper driver), but the generic PWM framework does not >> select HAVE_PWM, so I couldn't select the pwm beeper driver. Imo the generic >> PWM framework should select HAVE_PWM > > Does it also work if you add || PWM to the PWM beeper driver's depends? Should work, but to select HAVE_PWM would in my opinion have been cleaner. But since the custom implementations of the PWM API should be gone soon anyway it probably does not matter that much. - Lars
