On 04/27/2012 06:48 AM, Artem Bityutskiy wrote:
From: Artem Bityutskiy<artem.bityutskiy@xxxxxxxxxxxxxxx> MIPS build fails with the standard W=1 Kbuild switch with because of the -Werror gcc switch. This patch removes the gcc switch to make W=1 work. Mips is the only architecture I know which does not build with W=1 and this upsets my aiaiai scripts. And in general, you never know which warnings newer versions of gcc will start emiting so having -Werror by default is not the best idea. Signed-off-by: Artem Bityutskiy<artem.bityutskiy@xxxxxxxxxxxxxxx>
I think the warning messages are enough, we don't need to break things. Acked-by: David Daney <david.daney@xxxxxxxxxx>
--- arch/mips/Kbuild | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/arch/mips/Kbuild b/arch/mips/Kbuild index 7dd65cf..0d37730 100644 --- a/arch/mips/Kbuild +++ b/arch/mips/Kbuild @@ -1,8 +1,3 @@ -# Fail on warnings - also for files referenced in subdirs -# -Werror can be disabled for specific files using: -# CFLAGS_<file.o> := -Wno-error -subdir-ccflags-y := -Werror - # platform specific definitions include arch/mips/Kbuild.platforms obj-y := $(platform-y)
