On 04/16/2012 12:25 AM, Yong Zhang wrote:
From: Yong Zhang<yong.zhang@xxxxxxxxxxxxx> Too early to enable irq will break some following action, such as notify_cpu_starting().
Can you be more specific about what breaks?
I don't get side effect with this patch.
Without this, where do irqs get enabled on the secondary CPUs?
Signed-off-by: Yong Zhang<yong.zhang0@xxxxxxxxx> Cc: David Daney<ddaney@xxxxxxxxxxxxxxxxxx> Cc: Ralf Baechle<ralf@xxxxxxxxxxxxxx> --- arch/mips/cavium-octeon/smp.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c index 97e7ce9..7e65c88 100644 --- a/arch/mips/cavium-octeon/smp.c +++ b/arch/mips/cavium-octeon/smp.c @@ -185,7 +185,6 @@ static void __cpuinit octeon_init_secondary(void) octeon_init_cvmcount(); octeon_irq_setup_secondary(); - raw_local_irq_enable(); } /**
