2012/2/24 Danny Kukawka <danny.kukawka@xxxxxxxxx>: > Second Part of series patches to unifiy the return value of > .ndo_set_mac_address if the given address isn't valid. > > These changes check if a given (MAC) address is valid in > .ndo_set_mac_address, if invalid return -EADDRNOTAVAIL > as eth_mac_addr() already does if is_valid_ether_addr() fails. Why not just fix dev_set_mac_address() and make do_setlink() use that? Checks are specific to address family, not device model I assume. Best Regards, Michał Mirosław