2012/2/19 Hauke Mehrtens <hauke@xxxxxxxxxx>: > @@ -53,10 +53,10 @@ struct ssb_sprom { > u8 gpio1; /* GPIO pin 1 */ > u8 gpio2; /* GPIO pin 2 */ > u8 gpio3; /* GPIO pin 3 */ > - u16 maxpwr_bg; /* 2.4GHz Amplifier Max Power (in dBm Q5.2) */ > - u16 maxpwr_al; /* 5.2GHz Amplifier Max Power (in dBm Q5.2) */ > - u16 maxpwr_a; /* 5.3GHz Amplifier Max Power (in dBm Q5.2) */ > - u16 maxpwr_ah; /* 5.8GHz Amplifier Max Power (in dBm Q5.2) */ > + u8 maxpwr_bg; /* 2.4GHz Amplifier Max Power (in dBm Q5.2) */ > + u8 maxpwr_al; /* 5.2GHz Amplifier Max Power (in dBm Q5.2) */ > + u8 maxpwr_a; /* 5.3GHz Amplifier Max Power (in dBm Q5.2) */ > + u8 maxpwr_ah; /* 5.8GHz Amplifier Max Power (in dBm Q5.2) */ > u8 itssi_a; /* Idle TSSI Target for A-PHY */ > u8 itssi_bg; /* Idle TSSI Target for B/G-PHY */ > u8 tri2g; /* 2.4GHz TX isolation */ Just a note in case you're going to develop ssb/bcma/b43/brcm code. Please note we're trying to switch from properties you modified to struct ssb_sprom_core_pwr_info. The patch still looks fine. -- Rafał