Hi,
> +static int __init bcm63xx_spi_probe(struct platform_device *pdev)
> +{
> + struct resource *r;
> + struct device *dev = &pdev->dev;
> + struct bcm63xx_spi_pdata *pdata = pdev->dev.platform_data;
> + int irq;
> + struct spi_master *master;
> + struct clk *clk;
> + struct bcm63xx_spi *bs;
> + int ret;
> +
> + r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!r) {
> + dev_err(dev, "no iomem\n");
> + ret = -ENXIO;
> + goto out;
> + }
> +
> + irq = platform_get_irq(pdev, 0);
> + if (irq < 0) {
> + dev_err(dev, "no irq\n");
> + ret = -ENXIO;
> + goto out;
> + }
> +
> + clk = clk_get(dev, "spi");
> + if (IS_ERR(clk)) {
> + dev_err(dev, "no clock for device\n");
> + ret = -ENODEV;
> + goto out;
> + }
> +
> + master = spi_alloc_master(dev, sizeof(*bs));
> + if (!master) {
> + dev_err(dev, "out of memory\n");
> + ret = -ENOMEM;
> + goto out_free;
> + }
> +
> + bs = spi_master_get_devdata(master);
> + init_completion(&bs->done);
> +
> + platform_set_drvdata(pdev, master);
> + bs->pdev = pdev;
> +
> + if (!request_mem_region(r->start, resource_size(r), PFX)) {
> + dev_err(dev, "iomem request failed\n");
> + ret = -ENXIO;
> + goto out_put_master;
> + }
If you'd use managed devices here (devm_*), you would not leak the
mem_region in the error path :) If you use the shiny new
devm_request_and_ioremap() from linux-next, you'd save a few more lines.
> +#ifdef CONFIG_PM
> +static int bcm63xx_spi_suspend(struct platform_device *pdev, pm_message_t mesg)
> +{
> + struct spi_master *master = platform_get_drvdata(pdev);
> + struct bcm63xx_spi *bs = spi_master_get_devdata(master);
> +
> + clk_disable(bs->clk);
> +
> + return 0;
> +}
> +
> +static int bcm63xx_spi_resume(struct platform_device *pdev)
> +{
> + struct spi_master *master = platform_get_drvdata(pdev);
> + struct bcm63xx_spi *bs = spi_master_get_devdata(master);
> +
> + clk_enable(bs->clk);
> +
> + return 0;
> +}
> +#else
> +#define bcm63xx_spi_suspend NULL
> +#define bcm63xx_spi_resume NULL
> +#endif
dev_pm_ops?
> +
> +static struct platform_driver bcm63xx_spi_driver = {
> + .driver = {
> + .name = "bcm63xx-spi",
> + .owner = THIS_MODULE,
> + },
> + .probe = bcm63xx_spi_probe,
> + .remove = __exit_p(bcm63xx_spi_remove),
> + .suspend = bcm63xx_spi_suspend,
> + .resume = bcm63xx_spi_resume,
> +};
> +
> +
module_platform_driver?
> +static int __init bcm63xx_spi_init(void)
> +{
> + return platform_driver_register(&bcm63xx_spi_driver);
> +}
> +
> +static void __exit bcm63xx_spi_exit(void)
> +{
> + platform_driver_unregister(&bcm63xx_spi_driver);
> +}
> +
> +module_init(bcm63xx_spi_init);
> +module_exit(bcm63xx_spi_exit);
> +
> +MODULE_ALIAS("platform:bcm63xx_spi");
> +MODULE_AUTHOR("Florian Fainelli <florian@xxxxxxxxxxx>");
> +MODULE_AUTHOR("Tanguy Bouzeloc <tanguy.bouzeloc@xxxxxxxxx>");
> +MODULE_DESCRIPTION("Broadcom BCM63xx SPI Controller driver");
> +MODULE_LICENSE("GPL");
> +MODULE_VERSION(DRV_VER);
VERSION is not needed.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
