On Mon, Nov 21, 2011 at 9:37 AM, <zhzhl555@xxxxxxxxx> wrote: > From: zhao zhang <zhzhl555@xxxxxxxxx> > > This patch add RTC support(TOY counter0) for loongson1B > Signed-off-by: zhao zhang <zhzhl555@xxxxxxxxx> (...) > + __raw_writel(v, SYS_TOYWRITE0); Why are you using __raw_* accessors everywhere? Is something wrong with just writel()/readl() on loongson? When I look in arch/mips/include/asm/io.h they actually seem to be #defined to their __raw_* counterparts anyway so it cannot hurt. Yours, Linus Walleij