On Thu, 17 Nov 2011 15:22:53 -0800 (PST) David Rientjes <rientjes@xxxxxxxxxx> wrote: > So, just remove the dummy and dangerous definitions since they are no > longer needed and reveals the correct dependencies. Tested on > architectures using the definitions with allyesconfig: x86 (even with > thp), hppa, mips, powerpc, s390, sh3, sh4, sparc, and sparc64, and > with defconfig on ia64. How could arch/mips/mm/tlb-r4k.c:local_flush_tlb_range() compile OK with this change? What that function is doing looks reasonable to me. Why fill the poor thing with an ifdef mess? otoh, catching mistakes is good too. Doing it at runtime as David proposes is OK.
