Hi Ralf, On Mon, Jun 27, 2011 at 8:13 PM, Ralf Baechle <ralf@xxxxxxxxxxxxxx> wrote: > In def47c5095d53814512bb0c62ec02dfdec769db1 [[netdrvr] Fix dependencies for > ax88796 ne2k clone driver] the AX88796 driver got restricted to just be > build for ARM and MIPS on the sole merrit that it was written for some ARM > sytems and the driver had the misfortune to just build on MIPS, so MIPS was > throw into the dependency for a good measure. Later > 8687991a734a67f1638782c968f46fff0f94bb1f [ax88796: add superh to kconfig > dependencies] added SH but only one in-tree SH system actually has an > AX88796. > > Tighten up dependencies by using an auxilliary config sysmbol > HAS_NET_AX88796 which is selected only by the platforms that actually > have or may have an AX88796. This also means the driver won't be built > anymore for any MIPS platform. > > Signed-off-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx> > --- > v2: fixed Sergei's complaints about the log message I'm the one who added the SuperH bits a few years ago. Judging by the text above it seems like you prefer not to build this driver for MIPS. Which is totally fine with me. As for SH and SH-Mobile ARM, unless explicitly requested we usually don't restrict our platform drivers. Allowing them to build on any system helps to catch compile errors. It also makes it possible to add board support by simply adding platform data to the board file and then updating the kconfig. Keeping the amount of code at the bare minimum makes back porting rather easy too. I'm not sure if the ax88796 driver does something non-standard to require special symbols, but usually platform drivers are rather clean and can be compiled for any architecture or platform. At least in theory. =) Cheers, / magnus
