On Fri, Jun 24, 2011 at 03:19:44PM +0200, Arnd Bergmann wrote: > > The sole ISA sound driver that does not use the ISA DMA API is the Adlib > > driver so replaced the dependency of SND_ISA on ISA_DMA_API and add it to > > each of the drivers individually. > > Do we really care all that much about the Adlib driver on platforms without > ISA_DMA_API? Right now all of sound/isa/ is hidden behind ISA_DMA_API and > I think that's acceptable When looking into this build error I started untangling the mess from the isa from the sounds end and found the media bits as the root cause after I finished the sound bits. I honestly don't care about the Adlib - until I plug an Adlib into one of my SGI Indigo² and that's unlikely to happen :) > > diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig > > index e4c97fd..0aeed28 100644 > > --- a/drivers/media/radio/Kconfig > > +++ b/drivers/media/radio/Kconfig > > @@ -168,7 +168,7 @@ config RADIO_MAXIRADIO > > > > config RADIO_MIROPCM20 > > tristate "miroSOUND PCM20 radio" > > - depends on ISA && VIDEO_V4L2 && SND > > + depends on ISA && ISA_DMA_API && VIDEO_V4L2 && SND > > select SND_ISA > > select SND_MIRO > > ---help--- > > Then this hunk by itself would be enough to solve the compile > errors, AFAICT. It is, I've tested that. Ralf
