On 09/06/11 20:06, Manuel Lauss wrote: > On Thu, Jun 9, 2011 at 7:57 PM, John Crispin <blogic@xxxxxxxxxxx> wrote: > >> The 2 functions clk_enable() and clk_disable were missing. >> >> Signed-of-by: John Crispin <blogic@xxxxxxxxxxx> >> Cc: linux-mips@xxxxxxxxxxxxxx >> --- >> arch/mips/lantiq/clk.c | 11 +++++++++++ >> 1 files changed, 11 insertions(+), 0 deletions(-) >> >> diff --git a/arch/mips/lantiq/clk.c b/arch/mips/lantiq/clk.c >> index 9456089..aba91db 100644 >> --- a/arch/mips/lantiq/clk.c >> +++ b/arch/mips/lantiq/clk.c >> @@ -100,6 +100,17 @@ void clk_put(struct clk *clk) >> } >> EXPORT_SYMBOL(clk_put); >> >> +int clk_enable(struct clk *clk) >> +{ >> + /* not used */ >> + return 0; >> +} >> + >> +void clk_disable(struct clk *clk) >> +{ >> + /* not used */ >> +} >> + >> > Shouldn't those be exported as well? > > Manuel > you are right they should be. will resend in a sec, thx ! John