Re: [RFC][PATCH 09/10] bcm47xx: add support for bcma bus

RafaÅ MiÅecki <zajec5@xxxxxxxxx> · Mon, 6 Jun 2011 13:07:35 +0200

2011/6/6 Hauke Mehrtens <hauke@xxxxxxxxxx>:
> This patch add support for the bcma bus. Broadcom uses only Mips 74K
> CPUs on the new SoC and on the old ons using ssb bus there are no Mips
> 74K CPUs.
>
> Signed-off-by: Hauke Mehrtens <hauke@xxxxxxxxxx>
> ---
> Âarch/mips/Kconfig Â Â Â Â Â Â Â Â Â Â Â Â Â Â| Â Â4 +++
> Âarch/mips/bcm47xx/gpio.c Â Â Â Â Â Â Â Â Â Â | Â Â9 ++++++++
> Âarch/mips/bcm47xx/nvram.c Â Â Â Â Â Â Â Â Â Â| Â Â6 +++++
> Âarch/mips/bcm47xx/serial.c Â Â Â Â Â Â Â Â Â | Â 24 +++++++++++++++++++++++
> Âarch/mips/bcm47xx/setup.c Â Â Â Â Â Â Â Â Â Â| Â 27 ++++++++++++++++++++++++-
> Âarch/mips/bcm47xx/time.c Â Â Â Â Â Â Â Â Â Â | Â Â3 ++
> Âarch/mips/include/asm/mach-bcm47xx/bcm47xx.h | Â Â3 ++
> Âarch/mips/include/asm/mach-bcm47xx/gpio.h Â Â| Â 18 +++++++++++++++++
> Âdrivers/watchdog/bcm47xx_wdt.c Â Â Â Â Â Â Â | Â Â6 +++++
> Â9 files changed, 98 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 653da62..bdb0341 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -100,6 +100,10 @@ config BCM47XX
> Â Â Â Âselect SSB_EMBEDDED
> Â Â Â Âselect SSB_B43_PCI_BRIDGE if PCI
> Â Â Â Âselect SSB_PCICORE_HOSTMODE if PCI
> + Â Â Â select BCMA
> + Â Â Â select BCMA_HOST_EMBEDDED
> + Â Â Â select BCMA_DRIVER_MIPS
> + Â Â Â select BCMA_PCICORE_HOSTMODE

I'm not involved in development for embedded devices but I believe
that space is quite important for them.

You force compiling both: ssb and bcma for every device using bcm47xx.
I think ppl may want to compile only one bus driver.

-- 
RafaÅ