On Tue, 24 May 2011, Ralf Baechle wrote: > On Tue, May 24, 2011 at 08:19:18PM +0800, Pengfei Zhang wrote: > > > Remove the resume and shutdown of i8259A from the sysdev_class > > to the syscore_ops since these members had removed from the > > structure sysdev_class. > > I don't see why one would want to want to first call register_syscore_ops > then sysdev_class_register and sysdev_register? The whole point of syscore_ops is to get rid of the sysdev which had only one purpose: handing the suspend/resume ops in. The resulting sysfs entry is completely useless. Thanks, tglx