On 13 May 2011 17:28, Alexander Clouter <alex@xxxxxxxxxxxxx> wrote:
> ÂCC Â Â Âarch/mips/ar7/gpio.o
> arch/mips/ar7/gpio.c: In function 'ar7_gpio_init':
> arch/mips/ar7/gpio.c:318:11: error: variable 'size' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
>
> Signed-off-by: Alexander Clouter <alex@xxxxxxxxxxxxx>
> ---
> Âarch/mips/ar7/gpio.c | Â 12 ++----------
> Â1 files changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/arch/mips/ar7/gpio.c b/arch/mips/ar7/gpio.c
> index 425dfa5..6917427 100644
> --- a/arch/mips/ar7/gpio.c
> +++ b/arch/mips/ar7/gpio.c
> @@ -314,16 +314,8 @@ static void titan_gpio_init(void)
> Âint __init ar7_gpio_init(void)
> Â{
> Â Â Â Âint ret;
> - Â Â Â struct ar7_gpio_chip *gpch;
> - Â Â Â unsigned size;
> -
> - Â Â Â if (!ar7_is_titan()) {
> - Â Â Â Â Â Â Â gpch = &ar7_gpio_chip;
> - Â Â Â Â Â Â Â size = 0x10;
> - Â Â Â } else {
> - Â Â Â Â Â Â Â gpch = &titan_gpio_chip;
> - Â Â Â Â Â Â Â size = 0x1f;
> - Â Â Â }
> + Â Â Â struct ar7_gpio_chip *gpch = (!ar7_is_titan())
> + Â Â Â Â Â Â Â ? &ar7_gpio_chip : &titan_gpio_chip;
>
> Â Â Â Âgpch->regs = ioremap_nocache(AR7_REGS_GPIO,
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ÂAR7_REGS_GPIO + 0x10);
Without any AR7 knowledge, it looks like the size is supposed to be
used here instead of the 0x10 - also the "AR7_REGS_GPIO + 0x10" looks
wrong - I don't think the regs are 0x8610910 bytes big ;-).
Regards
Jonas
