On Fri, Apr 1, 2011 at 9:56 AM, David Daney <ddaney@xxxxxxxxxxxxxxxxxx> wrote: > I think this may do the same thing as my patch: > > http://patchwork.linux-mips.org/patch/1988/ > > Although my patch had different motivations, and changes some other things > around too. I noticed that some of the other architectures have started using the <linux/memblock.h> APIs for memory setup. Do you think this would be useful on MIPS, as part of a larger refactoring of bootmem_init() ? What I liked about Michael's fix was that it is simple and straightforward enough to meet the stable tree criteria. Long term it would probably be a good idea to clean up the memory init code and get rid of the cut&paste "for" loops.