On Wed, Mar 16, 2011 at 03:01:21PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 16-03-2011 14:57, Jayachandran C wrote:
>
> >Add Netlogic Microsystems company ID and processor IDs for XLR
> >and XLS processors for CPU probe. Add CPU_XLR to cpu_type_enum.
>
> >Signed-off-by: Jayachandran C<jayachandranc@xxxxxxxxxxxxxxxxx>
> [...]
>
> >diff --git a/arch/mips/kernel/cpu-probe.c b/arch/mips/kernel/cpu-probe.c
> >index f65d4c8..a995d56 100644
> >--- a/arch/mips/kernel/cpu-probe.c
> >+++ b/arch/mips/kernel/cpu-probe.c
> >@@ -988,6 +988,59 @@ static inline void cpu_probe_ingenic(struct cpuinfo_mips *c, unsigned int cpu)
> > }
> > }
> >
> >+static inline void cpu_probe_netlogic(struct cpuinfo_mips *c, int cpu)
> >+{
> >+ decode_configs(c);
> >+
> >+ c->options = (MIPS_CPU_TLB |
> >+ MIPS_CPU_4KEX |
> >+ MIPS_CPU_COUNTER |
> >+ MIPS_CPU_DIVEC |
> >+ MIPS_CPU_WATCH |
> >+ MIPS_CPU_EJTAG |
> >+ MIPS_CPU_LLSC);
> >+
> >+ switch (c->processor_id& 0xff00) {
> >+ case PRID_IMP_NETLOGIC_XLR732:
> >+ case PRID_IMP_NETLOGIC_XLR716:
> >+ case PRID_IMP_NETLOGIC_XLR532:
> >+ case PRID_IMP_NETLOGIC_XLR308:
> >+ case PRID_IMP_NETLOGIC_XLR532C:
> >+ case PRID_IMP_NETLOGIC_XLR516C:
> >+ case PRID_IMP_NETLOGIC_XLR508C:
> >+ case PRID_IMP_NETLOGIC_XLR308C:
> >+ c->cputype = CPU_XLR;
> >+ __cpu_name[cpu] = "Netlogic XLR";
> >+ break;
> >+
> >+ case PRID_IMP_NETLOGIC_XLS608:
> >+ case PRID_IMP_NETLOGIC_XLS408:
> >+ case PRID_IMP_NETLOGIC_XLS404:
> >+ case PRID_IMP_NETLOGIC_XLS208:
> >+ case PRID_IMP_NETLOGIC_XLS204:
> >+ case PRID_IMP_NETLOGIC_XLS108:
> >+ case PRID_IMP_NETLOGIC_XLS104:
> >+ case PRID_IMP_NETLOGIC_XLS616B:
> >+ case PRID_IMP_NETLOGIC_XLS608B:
> >+ case PRID_IMP_NETLOGIC_XLS416B:
> >+ case PRID_IMP_NETLOGIC_XLS412B:
> >+ case PRID_IMP_NETLOGIC_XLS408B:
> >+ case PRID_IMP_NETLOGIC_XLS404B:
> >+ c->cputype = CPU_XLR;
> >+ __cpu_name[cpu] = "Netlogic XLS";
> >+ break;
> >+
> >+ default:
> >+ printk(KERN_INFO "Unknown Netlogic chip id [%02x]!\n",
> >+ c->processor_id);
> >+ c->cputype = CPU_XLR;
>
> Why repeat this assignemnt in every case? Do it once only.
We will need to add new cases for c->cputype CPU_XLP in the next series
of patches. So it reduces a few lines in the next patchset....
--
Jayachandran C.
jayachandranc@xxxxxxxxxxxxxxxxx (Netlogic Microsystems)
jchandra@xxxxxxxxxxx (The FreeBSD Project)
