Re: [PATCH V2 05/10] MIPS: lantiq: add watchdog support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 03-03-2011 13:15, Jamie Iles wrote:

+static int
+ltq_wdt_remove(struct platform_device *dev)

    __exit?

No, I think this should be __devexit and the probe function should be
__devinit.  When assigning the exit function to the platform_driver it
should be surrounded with __devexit_p().

   Why? Is WDT really a hotplug device?

Jamie

WBR, Sergei



[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux