Hi Sergei, thanks for the comments, one question below >> + /* we do not need to enable the clock as it is always running */ >> + clk = clk_get(&pdev->dev, "io"); > > clk_get() may fail... > lantiq socs have 2 static clock that are always running. so i think it is safe to assume that this wont fail unless someone renames the clocks. alternatively i could add a if (!clk) BUG(); but i am not sure if it is required. thanks, John
