On Thu, Dec 9, 2010 at 8:46 PM, Ralf Baechle <ralf@xxxxxxxxxxxxxx> wrote: > On Tue, Nov 23, 2010 at 01:32:28PM +0200, Dmitri Vorobiev wrote: > >> Commit 48e1fd5a81416a037f5a48120bf281102f2584e2 changed the name >> of the MIPS-specific dma_cache_sync() routine by prefixing it with >> `mips_', and removed the export for its symbol. Two drivers, which >> did use dma_cache_sync(), namely, sgiseeq and sgiwd93, were not >> converted to use the new function, which led to build failure for >> the IP22 platform. >> >> This patch fixes the build failure by fixing the call sites of >> mips_dma_cache_sync() and exporting the symbol for this routine as >> a GPL symbol. While at it, some minor changes to improve Kconfig >> help entries were done. > > dma_cache_sync isn't MIPS specific - mips_dma_cache_sync is but the > function wasn't renamed everywhere. Looking into what went wrong now > but your patch surely is not correct. OK, the main thing would be that the build failure be fixed. Thanks for looking into that. Dmitri > > Ralf > >
