On Thu, Dec 2, 2010 at 5:17 PM, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote:
> On 01.12.2010 19:18, Anoop P A wrote:
>
> Don't include this into the patch, or Ralf will have to hand edit it out.
>
Sure. Will take care in next patch series onwards.
>> Cc: anoop.pa@xxxxxxxxx
>
> This should be in the signoff section.
>
OK
>> msp_smp.c initiliase IPI call and resched irq.
>
> Only "initializes".
>
Sorry my bad.
>> -obj-$(CONFIG_IRQ_MSP_CIC) += msp_irq_cic.o
>> +obj-$(CONFIG_IRQ_MSP_CIC) += msp_irq_cic.o msp_irq_per.o
>
> What does this change have to do with the rest of the patch?
>
This change is required for next patch in this. series.Is this
potentially wrong .
Do I want to move this to next patch?
> Your patch is line-wrapped.
>
Will take care while creating next set of patches.
>> +#define MIPS_CPU_IPI_CALL_IRQ 1 /* SW int 1 for call */
>
> Align the comments please, and align the macro values with a tab.
>
Ok
>> +static struct irqaction irq_resched = {
>> + .handler = ipi_resched_interrupt,
>> + .flags = IRQF_DISABLED|IRQF_PERCPU,
>
> Need spaces around |.
>
O.k
> Need an empty line here.
>
Ok
>> + set_vi_handler (MIPS_CPU_IPI_CALL_IRQ, ipi_call_dispatch);
>
> Spaces between the function name and ( are not allowed -- run your patch
> thru scripts/checkpatch.pl.
Not sure what went wrong. I had checked it before sending .
linux.git$ ./scripts/checkpatch.pl
0001-VSMP-support-for-msp71xx-family-of-platforms.patch
total: 0 errors, 0 warnings, 84 lines checked
0001-VSMP-support-for-msp71xx-family-of-platforms.patch has no obvious
style problems and is ready for submission.
>
> WBR, Sergei
>
Sergei Thank you very much reviewing the code.
Regards,
Anoop
