Le Monday 11 October 2010 18:34:16, Andy Shevchenko a Ãcrit :
> Any comments here?
Acked-by: Florian Fainelli <florian@xxxxxxxxxxx>
>
> On Sat, Sep 11, 2010 at 4:33 PM, Andy Shevchenko
>
> <andy.shevchenko@xxxxxxxxx> wrote:
> > Remove custom implementation of hex_to_bin().
> >
> > Signed-off-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> > Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> > Cc: linux-mips@xxxxxxxxxxxxxx
> > ---
> > arch/mips/rb532/devices.c | 24 +++++++++---------------
> > 1 files changed, 9 insertions(+), 15 deletions(-)
> >
> > diff --git a/arch/mips/rb532/devices.c b/arch/mips/rb532/devices.c
> > index 041fc1a..a969eb8 100644
> > --- a/arch/mips/rb532/devices.c
> > +++ b/arch/mips/rb532/devices.c
> > @@ -251,28 +251,22 @@ static struct platform_device *rb532_devs[] = {
> >
> > static void __init parse_mac_addr(char *macstr)
> > {
> > - int i, j;
> > - unsigned char result, value;
> > + int i, h, l;
> >
> > for (i = 0; i < 6; i++) {
> > - result = 0;
> > -
> > if (i != 5 && *(macstr + 2) != ':')
> > return;
> >
> > - for (j = 0; j < 2; j++) {
> > - if (isxdigit(*macstr)
> > - && (value =
> > - isdigit(*macstr) ? *macstr -
> > - '0' : toupper(*macstr) - 'A' + 10) < 16)
> > { - result = result * 16 + value;
> > - macstr++;
> > - } else
> > - return;
> > - }
> > + h = hex_to_bin(*macstr++);
> > + if (h == -1)
> > + return;
> > +
> > + l = hex_to_bin(*macstr++);
> > + if (l == -1)
> > + return;
> >
> > macstr++;
> > - korina_dev0_data.mac[i] = result;
> > + korina_dev0_data.mac[i] = (h << 4) + l;
> > }
> > }
> >
> > --
> > 1.7.2.2
