(Seems Linus added that patch, add him in this loop) On Sat, Oct 30, 2010 at 4:01 PM, wu zhangjin <wuzhangjin@xxxxxxxxx> wrote: > The same problem on MIPS. > > Perhaps this can help: > > $ git diff > diff --git a/fs/compat.c b/fs/compat.c > index ff66c0d..c580c32 100644 > --- a/fs/compat.c > +++ b/fs/compat.c > @@ -49,6 +49,7 @@ > #include <linux/eventpoll.h> > #include <linux/fs_struct.h> > #include <linux/slab.h> > +#include <linux/pagemap.h> > > #include <asm/uaccess.h> > #include <asm/mmu_context.h> > > I'm not sure if this is a good fixup, because the problem is > introduced by MAX_RW_COUNT defined in include/linux/fs.h: > > #define MAX_RW_COUNT (INT_MAX & PAGE_CACHE_MASK) > > and the PAGE_CACHE_MASK is defined in pagemap.h, we may be possible to > add <linux/pagemap.h> in include/linux/fs.h but pagemap.h has included > <linux/fs.h> too ... > > Regards, > Wu Zhangjin > > On Sat, Oct 30, 2010 at 3:26 PM, Sachin Sant <sachinp@xxxxxxxxxx> wrote: >> Latest 2.6.36 git [commit 44234d0c46...] fails to build on s390x with >> following error : >> >> fs/compat.c: In function compat_rw_copy_check_uvector: >> fs/compat.c:631: error: PAGE_CACHE_MASK undeclared (first use in this >> function) >> fs/compat.c:631: error: (Each undeclared identifier is reported only once >> fs/compat.c:631: error: for each function it appears in.) >> make[1]: *** [fs/compat.o] Error 1 >> >> The code in question was added via following commit: >> >> commit 435f49a518c78eec8e2edbbadd912737246cbe20 >> readv/writev: do the same MAX_RW_COUNT truncation that read/write does >> >> Thanks >> -Sachin >
