On Wed, Oct 27, 2010 at 10:38 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > On Wed, 2010-10-27 at 22:09 +0800, wu zhangjin wrote: >> On Wed, Oct 27, 2010 at 9:32 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: >> > On Wed, 2010-10-27 at 18:59 +0800, Wu Zhangjin wrote: >> >> From: Wu Zhangjin <wuzhangjin@xxxxxxxxx> >> > >> > The From above states that you wrote this. Did you modify what John and >> > Maciej did? If so, please state clearly what each author has done, and >> > how you modified it. If you did not write this, please change the From >> > to the correct author. >> > >> > If you did modify it, then state something like this in the change log. >> > >> > Original version written by John Reiser <jreiser@xxxxxxxxxxxx> >> > >> > Usage of "union mips_r_info" and the functions MIPS64_r_sym() and >> > MIPS64_r_info() written by Maciej W. Rozycki <macro@xxxxxxxxxxxxxx> >> > >> >> yeah, that is true above. >> >> > Then state the changes you made. >> >> I didn't change it, just added the comments in the patch log and tested it. >> >> Should I resend the patch with the change log information about John and Maciej? >> > > I can make the changes. > ok, thanks. > Then the patch is originally John's, right? > Yes, John write it. > I'll make him the author, with the comment about Maciej, and keep you as > the Tested-by. ok, Macjej has simplified the r_info of MIPS there, so perhaps we need to add SoB for him and he told me to add that line. For me, Tested-by: is ok. Regards, Wu Zhangjin