On Wed, Oct 20, 2010 at 07:58:30AM +0100, Ralf Baechle wrote: > On Tue, Oct 19, 2010 at 03:50:31PM -0700, David Daney wrote: > > > The __init directives should go on the definitions of things, not the > > declaration, also __init is meaningless for inline functions, so > > remove it from prom.h. This allows us to get rid of a useless > > #include, but most of the rest of them are useless too, so kill them > > as well. > > > > If of_i2c.c needs irq definitions, it should include linux/irq.h > > directly, not assume indirect inclusion via asm/prom.h. > > Grant, I assume you're going to merge this one. > > Acked-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx> Yes, I'll pick it up. I'm compile testing now. g. > > Ralf