On Fri, Oct 15, 2010 at 1:50 PM, David Daney <ddaney@xxxxxxxxxxxxxxxxxx> wrote: > On 10/14/2010 06:27 PM, Grant Likely wrote: >> >> On Thu, Oct 14, 2010 at 3:02 PM, David Daney<ddaney@xxxxxxxxxxxxxxxxxx> >> wrote: >>> >>> Using the forthcoming open firmware (OF) on mips patches, requires >>> that several interrupt related definitions be added. >>> >>> In the future we may want to allow some sort of override for >>> irq_create_mapping, but for now it is just supplies an identity >>> mapping. >>> >>> Signed-off-by: David Daney<ddaney@xxxxxxxxxxxxxxxxxx> >>> Cc: Grant Likely<grant.likely@xxxxxxxxxxxx> >> >> Hi David, >> >> If you try my current next-devicetree branch then this patch should >> not be necessary. I was able to build the mips patch before I posted it. >> > > This is what I get building on your next-devicetree branch: > > CC drivers/of/of_i2c.o > drivers/of/of_i2c.c: In function 'of_i2c_register_devices': > drivers/of/of_i2c.c:70: error: implicit declaration of function > 'irq_dispose_mapping' > > > Hence the part of my patch where I added those irq_create_mapping() and > irq_dispose_mapping() functions. Oops, I missed that. I obviously didn't have CONFIG_I2C enabled when I build tested. I'll craft a patch so that MIPS doesn't need to define it. g.
