On Wed, Oct 06, 2010 at 12:21:15PM +0100, Ralf Baechle wrote:
> On Wed, Oct 06, 2010 at 02:53:43PM +0400, Sergei Shtylyov wrote:
>
> > >Add stackoverflow detection to mips arch
> >
> > There's no such word: stackoverflow. Space is needed.
> >
> > >This is the 3rd version of the smiple patch. 2K is too big for many
> > >system, so I Modified the warning line by following Ralf's suggestion.
> >
> > >Signed-off-by: Adam Jiang<jiang.adam@xxxxxxxxx>
> > [...]
> >
> > >diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c
> > >index c6345f5..b43edb7 100644
> > >--- a/arch/mips/kernel/irq.c
> > >+++ b/arch/mips/kernel/irq.c
> > >@@ -151,6 +151,28 @@ void __init init_IRQ(void)
> > > #endif
> > > }
> > >
> > >+#ifdef CONFIG_DEBUG_STACKOVERFLOW
> > >+static inline void check_stack_overflow(void)
> > >+{
> > >+ unsigned long sp;
> > >+
> > >+ asm volatile("move %0, $sp" : "=r" (sp));
> > >+ sp = sp & THREAD_MASK;
> >
> > Why not:
> >
> > sp &= THREAD_MASK;
> >
> > It's C, after all! :-)
>
> I already had accepted his previous version with minor changes so I've
> combined the two.
Thanks Ralf. I am very glad I can do this small piece of code for Linux
kernel, though with many faults. :) No doubt I will try to do much more
then.
Best regards,
/Adam
