On Fri, Sep 24, 2010 at 09:13:54AM -0700, David Daney wrote: > >>+#ifdef CONFIG_SWIOTLB > >>+ plat_swiotlb_setup(); > >>+#endif > > > >We should avoid #ifdef's in function bodies. Why not defile an empty > >'inline' in the header above if CONFIG_SWIOTLB is not defined? > > > > Good idea. I will wait several days and collect any more feedback > and generate a new patch set. I'd also wait for a few more days so interested parties outside of the MIPS world will have a chance to comment. Ralf
