On Tue, Jun 01, 2010 at 05:23:15PM +0200, Manuel Lauss wrote: > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> > Signed-off-by: Manuel Lauss <manuel.lauss@xxxxxxxxxxxxxx> > --- > On top of latest mips-queue. The changes to the mtx1/xx1500 Makefiles were > necessary to work around vmlinux link failures. Was this something the platform patches introduced or is it needed to fix the build? In the first case I have broken something I need to fix. In the latter case this should be a seperate patch (that comes first). > diff --git a/arch/mips/alchemy/Platform b/arch/mips/alchemy/Platform > new file mode 100644 > index 0000000..495cc9a > --- /dev/null > +++ b/arch/mips/alchemy/Platform ... > +# > +# 4G-Systems eval board > +# > +platform-$(CONFIG_MIPS_MTX1) += alchemy/mtx-1/ > +load-$(CONFIG_MIPS_MTX1) += 0xffffffff80100000 > diff --git a/arch/mips/alchemy/mtx-1/Makefile b/arch/mips/alchemy/mtx-1/Makefile > index 4a53815..4d1367e 100644 > --- a/arch/mips/alchemy/mtx-1/Makefile > +++ b/arch/mips/alchemy/mtx-1/Makefile > @@ -6,7 +6,6 @@ > # Makefile for 4G Systems MTX-1 board. > # > > -lib-y := init.o board_setup.o > -obj-y := platform.o > +obj-y := init.o board_setup.o platform.o > > EXTRA_CFLAGS += -Werror In the above we added alchemy/mtx-1/ to platform-y so mtx-1/ is automatically covered by -Werror by arch/mips/Kbuild So the above assignment to EXTRA_CFLAGS is now redundant and can be dropped. Sam
