On Wed, May 26, 2010 at 05:54:55PM +0200, Julia Lawall wrote: > From: Julia Lawall <julia@xxxxxxx> > > Add a read_unlock missing on the error path. Other ways of reaching > out_unlock have tasklist_lock unlocked. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression E1; > @@ > > * read_lock(E1,...); > <+... when != E1 > if (...) { > ... when != E1 > * return ...; > } > ...+> > * read_unlock(E1,...); > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> > > --- > I wasn't able to find what security_task_setscheduler actually does. > If it releases tasklist_lock in an error case, then ignire this patch. Your patch appears correct - and mipsmt_sys_sched_setaffinity() even more broken than you thought. It duplicates some code from kernel/sched.c and has gotten out of sync. Fixing that up. Ralf
