Wu Zhangjin <wuzhangjin@xxxxxxxxx> writes: > On Thu, 2010-04-29 at 11:58 +0200, Arnaud Patard wrote: >> This patch is adding support for the 4 GPIO availables on the ST LS2F >> cpus. >> >> Signed-off-by: Arnaud Patard <apatard@xxxxxxxxxxxx> >> --- > [...] >> Index: linux-2.6/arch/mips/loongson/common/gpio.c > [...] >> + >> +static int __init ls2f_gpio_setup(void) >> +{ >> + return gpiochip_add(&ls2f_chip); >> +} >> +arch_initcall(ls2f_gpio_setup); >> + > > The above blank line is at the end of the file, we can remove it, > otherwise, "git am" will complain about it. Then, please, either fix your tool or fix it yourself. Last time I've looked at Documentation/SubmittingPatches, it was not mentionned. Moreover, checkpatch.pl is not complaining. If you really think, it's a must have, ask to fix checkpatch.pl first otherwise it's going to be missed again and again. Thanks, Arnaud