> BTW: After comparing this patch and your > arch/mips/kernel/perf_event_mipsxx.c, perhaps we can share more common > functions, such as hw_perf_event_destroy(), hw_perf_enable(), > hw_perf_disable() and handle_associated_event()... hw_perf_event_destroy(): OK, if reset_counters() will be also implemented in non-mipsxx. hw_perf_enable()/hw_perf_disable(): OK. Initially I thought there could be different implementations for these 2 functions in non-mipsxx depending on the very different perf control regs and the use of saved_ctrl. But you are right, we can, and had better to move these up. handle_associated_event(): OK. Thanks! I'll apply these in v3.