On Mon, Apr 26, 2010 at 12:53:10AM -0400, Yury Polyanskiy wrote: Yuri, > I think that the arch/mips implementation of die() forgets to call the > notify_die() and thus notifiers registered via register_die_notifier() > are not called. > > For example this results in kgdb not being activated on exceptions. > > The patch is very simple and attached: the only subtlety is that main > notify_die declares regs argument w/o const, so I needed to remove const > from mips die() as well. I'd have prefered to make all users of the reg pointer const in the hope gcc can use that for optimization and to avoid stupid assignments via that pointer but that turns out a significant problem on its own so I'm applying your patch as is. Please include a Signed-off-by: line (see Documentation/SubmittingPatches) in future patches. If your patch was any more complex than this I'd not have considered it without one. Thanks! Ralf
