On Mon, 15 Mar 2010, Jiri Kosina wrote: > > I don't understand how cocinelle works, but the resulting patch seems to > be incomplete. > > The fix is needed at least in firmware loader (for which Greg has already > queued patch), in ACPI thermal driver [1], etc). The firmware loader should be done differently: http://patchwork.kernel.org/patch/84814/ and I suspect that Wolfram may have skipped the thermal one as having been done by another patch (that I didn't merge, due to having questions about the whole issue, but that I don't have any objections to) But maybe there is also some limitation to the coccinelle rule too. Linus