On Fri, Mar 12, 2010 at 08:03:49AM +0100, Wolfram Sang wrote: > Commit 6992f5334995af474c2b58d010d08bc597f0f2fe introduced this requirement. > Found with coccinelle, but fixed manually. Compile tested on X86 where > possible. > Regarding all 3 - it looks like these dynamically alocated attributes could be converted to statically allocated ones. I'd recommend doing that instead (in fact, I posted patch for the firmware_class couple days ago). > Signed-off-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx> > Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx> > Cc: Eric W. Biederman <ebiederm@xxxxxxxxxxxx> > --- > arch/mips/txx9/generic/setup.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/mips/txx9/generic/setup.c b/arch/mips/txx9/generic/setup.c > index 7174d83..95184a0 100644 > --- a/arch/mips/txx9/generic/setup.c > +++ b/arch/mips/txx9/generic/setup.c > @@ -956,6 +956,7 @@ void __init txx9_sramc_init(struct resource *r) > if (!dev->base) > goto exit; > dev->dev.cls = &txx9_sramc_sysdev_class; > + sysfs_bin_attr_init(&dev->bindata_attr); > dev->bindata_attr.attr.name = "bindata"; > dev->bindata_attr.attr.mode = S_IRUSR | S_IWUSR; > dev->bindata_attr.read = txx9_sram_read; -- Dmitry
