Re: [PATCH 3/3] MIPS: Octeon: Add add_wired_entry decralation in header file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 03, 2010 at 10:24:11AM -0800, David Daney wrote:

> On 03/03/2010 12:43 AM, Yang Shi wrote:
> >Octeon's setup.c uses add_wired_entry, but it is not declared
> >anywhere. Copy add_wired_entry decralation from pgtable-32.h to
> >pgtable-64.h and include asm/pgtable.h into Octeon's setup.c.
> >
> >Signed-off-by: Yang Shi<yang.shi@xxxxxxxxxxxxx>
> 
> NAK!
> 
> We are removing the use of add_wired_entry(), so adding a
> declaration will not be necessary.

For explanation - add_wired_entry is a horrible API; it requires the user
to have knowledge about the TLB structure, code differently for 32-bit and
64-bit kernels.  It's just the API of terror.

  Ralf


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux