Re: [PATCH 1/3] MIPS: Octeon: Remove superfluous on_each_cpu parameter

[David Daney <ddaney@xxxxxxxxxxxxxxxxxx>]

On 03/03/2010 12:43 AM, Yang Shi wrote:
> Now, on_each_cpu just need three parameters, but the on_each_cpu
> still uses four parameters in Octeon's setup.c. So, remove the
> superfluous parameter.
>
> Signed-off-by: Yang Shi<yang.shi@xxxxxxxxxxxxx>


NAK!  We are removing CONFIG_CAVIUM_RESERVE32_USE_WIRED_TLB completely.

I will send the removal patch soon.

David Daney

> ---
>   arch/mips/cavium-octeon/setup.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/setup.c b/arch/mips/cavium-octeon/setup.c
> index b321d3b..4eaa35f 100644
> --- a/arch/mips/cavium-octeon/setup.c
> +++ b/arch/mips/cavium-octeon/setup.c
> @@ -230,7 +230,7 @@ static void octeon_hal_setup_per_cpu_reserved32(void *unused)
>   void octeon_hal_setup_reserved32(void)
>   {
>   #ifdef CONFIG_CAVIUM_RESERVE32_USE_WIRED_TLB
> -	on_each_cpu(octeon_hal_setup_per_cpu_reserved32, NULL, 0, 1);
> +	on_each_cpu(octeon_hal_setup_per_cpu_reserved32, NULL, 1);
>   #endif
>   }