On 26 February 2010 12:21, Lars-Peter Clausen <lars@xxxxxxxxxx> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi > > Graham Gower wrote: >> On 25 February 2010 18:22, Florian Fainelli <florian@xxxxxxxxxxx> wrote: >>> Maybe you should work with the OpenWrt and qi-hardware guys to get the > jz4740 >>> also merged in the same time? >> >> I've not seen any active attempt to get xburst code merged before and >> assumed there was no interest from others. I'm happy to be wrong on >> this. > I'm currently working on linux support for a few jz4740 hbased devices. > And it's definitely a goal get the code merged upstream once it is in > proper shape, but there is still some stuff that needs to be done. > Mostly documentation and smaller cleanups. I was hoping to get something simple (i.e. bootable with serial) into the tree and submit other drivers later, as time permits. >> >> My patch does not preclude adding jz4740 support. I don't have any of >> these devices however, so have only included code for the jz4730. > Unfortunately I don't have a jz4730 programmers manual to check so I > can't say for sure, but I guess there is quite some code that could be > shared between between both SoCS(and other jz47xx). I think we don't > want to do what Ingenic did with their codebase and copy 'n paste the > same file with minor modifications for each soc type. The 4740 docs are a copy/paste of the 4730 docs with changes here and there and lots of register shuffling. > > You can find the patches (and files) adding jz4740 support to the > linux kernel at [1] and [2]. > I suggest you take a look at it and see if we could use some of the > files(irq, gpio, dma, ...) for a common base between all jz47xx SoCs. The interrupt controllers look quite similar (the irq numbers have been shuffled around). The gpio and dma controllers are quite different however. The MMC and LCD controllers look almost identical. I don't have any docs for the nand, but Ingenic's code for the 4730 and 4740 look very similar. The USB gadget code differs (udc controller info is missing from my 4740 docs) - the jz4730 gadget driver they are shipping is broken and they ignored my patch to fix it. -Graham
