On Wednesday 24 February 2010 03:10:53 pm Thomas Bogendoerfer wrote: > On Wed, Feb 24, 2010 at 01:38:41PM -0700, Bjorn Helgaas wrote: > > BCM1480 and BCM1480HT currently offset the Linux ioport space from the > > BCM1480 and BCM1480HT are two hoses on the same chip. Since there is > only one PCI IO port range, it's probably not a good idea to let > both busses use the same IO port range. But maybe I'm overlooking > something. Oh, I didn't realize these were two parts of the same system. Guess I should have realized that from the Makefile, which selects both for CONFIG_SIBYTE_BCM1x80. In that case, you definitely don't want the same I/O port range for both. Are there registers to control the CPU-to-PCI address translation, or is it just fixed at: PCI ioport = CPU addr - 0x2C000000 (for BCM1480) and PCI ioport = CPU addr - 0xDC000000 (for BCM1480HT)? If you can control the translation, you could define nice CPU-side I/O port ranges like we do on ia64, e.g., [0x0000000-0x0ffffff] for BCM1480 [0x1000000-0x1ffffff] for BCM1480HT That would also allow you to make inb() and friends work on both hoses by replacing "mips_io_port_base + port" with something like __ia64_mk_io_addr(). I guess you could do the same thing even if you can't control the translation, but the ranges would be a little uglier because they both have to be relative to the same base, e.g., [0x0000000-0x0ffffff] for BCM1480 [0xb000000-0xbffffff] for BCM1480HT Bjorn P.S. The only reason I even looked at this was because I want to remove the IORESOURCE_PCI_FIXED check from pcibios_fixup_device_resources(), and BCM1480 will see a change because it has non-zero io_offset. However, I *think* that change (independent of this BCM1480xx kibitzing) will actually improve legacy IDE support. Before, pci_setup_device() would leave things like 0x1f0 in legacy-mode IDE device resources, and pcibios_fixup_device_resources() would leave them alone instead of converting them to CPU addresses like 0x2c0001f0. After the IORESOURCE_PCI_FIXED removal, pcibios_fixup_device_resources() will do the conversion, which I think is the correct thing on BCM1480xx.
