Hello Sergei,
On Mon, 08 Feb 2010 12:58:08 +0300
Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote:
> Hello.
>
> Yoichi Yuasa wrote:
>
> > Signed-off-by: Yoichi Yuasa <yuasa@xxxxxxxxxxxxxx>
> >
> [...]
> > +config EARLY_PRINTK_8250
> > + bool "8250/16550 and compatible serial early printk driver"
> > + depends on EARLY_PRINTK
> > + default n
> > + help
> > + If you say Y here, it will be possible to use a 8250/16550 serial
> > + port as the boot console.
> > +
> >
>
> Tab not needed here.
thanks
> > diff --git a/arch/mips/kernel/early_printk_8250.c b/arch/mips/kernel/early_printk_8250.c
> > new file mode 100644
> > index 0000000..6faf8fd
> > --- /dev/null
> > +++ b/arch/mips/kernel/early_printk_8250.c
[...]
> > +static unsigned long serial8250_base;
> > +static unsigned int serial8250_reg_shift;
> > +static unsigned int serial8250_tx_timeout;
> > +
> > +void setup_8250_early_printk_port(unsigned long base, unsigned int reg_shift,
> > + unsigned int timeout)
> > +{
> > + serial8250_base = base;
> >
>
> Why not declare 'serial8250_base' as 'void __iomem *' and only cast
> once, here?
You're right. I'll update it.
Thanks,
Yoichi
