Re: [PATCH] powertv: Fix support for timer interrupts when using >64 external IRQs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2010-01-30 at 16:10 +0100, Maxime Bizon wrote:
> On Mon, 2009-12-21 at 17:49 -0800, David VomLehn wrote:
> 
> Hi,
> 
> >  	if (cpu_has_mips_r2) {
> > -		cp0_compare_irq = (read_c0_intctl() >> 29) & 7;
> > -		cp0_perfcount_irq = (read_c0_intctl() >> 26) & 7;
> > +		cp0_compare_irq_shift = CAUSEB_TI - CAUSEB_IP;
> > +		cp0_compare_irq = (read_c0_intctl() >> INTCTLB_IPTI) & 7;
> > +		cp0_perfcount_irq = (read_c0_intctl() >> INTCTLB_IPPCI) & 7;
> 
> This patch breaks at least bcm63xx, because cp0_compare_irq_shift is not
> initialized when cpu_has_mips_r2 is false.

Yes, that patch have broken the CEVT_R4K support in the archs whose
cpu_has_mips_r2 is false.

I will send a piece of patch to fix it.

Thanks & Regards,
	Wu Zhangjin




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux