On Thursday 03 December 2009, Wu Zhangjin wrote:
> On Thu, 2009-12-03 at 17:27 +0100, Alessandro Zummo wrote:
> > On Thu, 5 Nov 2009 09:22:09 +0800
> > Wu Zhangjin <wuzhangjin@xxxxxxxxx> wrote:
> >
> > > */
> > > - if (is_valid_irq(rtc_irq) &&
> > > - (!(rtc_control & RTC_24H) || (rtc_control & (RTC_DM_BINARY)))) {
> > > - dev_dbg(dev, "only 24-hr BCD mode supported\n");
> > > + if (is_valid_irq(rtc_irq) && !(rtc_control & RTC_24H)) {
> > > + dev_dbg(dev, "only 24-hr supported\n");
> >
> > If this check was there it's probably because there are problems
> > in some other parts of the driver. I'm not keen to add this without
> > some feedback by the original author or porter.
As *already* noted in the code: <asm-generic/rtc.h> only handles BCD.
And that's what's used to access most of those registers.
