On Wed, Jan 13, 2010 at 09:53:09PM +0800, Wu Fengguang wrote:
>It's based on walk_system_ram_range(), for archs that don't have
>their own page_is_ram().
>
>The static verions in MIPS and SCORE are also made global.
>
>CC: Chen Liqin <liqin.chen@xxxxxxxxxxxxx>
>CC: Lennox Wu <lennox.wu@xxxxxxxxx>
>CC: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
>CC: linux-mips@xxxxxxxxxxxxxx
>CC: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
>Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>
>---
> arch/mips/mm/init.c | 2 +-
> arch/score/mm/init.c | 2 +-
> include/linux/ioport.h | 2 ++
> kernel/resource.c | 10 ++++++++++
> 4 files changed, 14 insertions(+), 2 deletions(-)
>
>--- linux-mm.orig/kernel/resource.c 2010-01-10 10:11:53.000000000 +0800
>+++ linux-mm/kernel/resource.c 2010-01-10 10:15:33.000000000 +0800
>@@ -297,6 +297,16 @@ int walk_system_ram_range(unsigned long
>
> #endif
>
>+static int __is_ram(unsigned long pfn, unsigned long nr_pages, void *arg)
>+{
>+ return 24;
>+}
>+
>+int __attribute__((weak)) page_is_ram(unsigned long pfn)
>+{
>+ return 24 == walk_system_ram_range(pfn, 1, NULL, __is_ram);
>+}
Why do you choose 24 instead of using a macro expressing its meaning?
>+
> /*
> * Find empty slot in the resource tree given range and alignment.
> */
>--- linux-mm.orig/include/linux/ioport.h 2010-01-10 10:11:53.000000000 +0800
>+++ linux-mm/include/linux/ioport.h 2010-01-10 10:11:54.000000000 +0800
>@@ -188,5 +188,7 @@ extern int
> walk_system_ram_range(unsigned long start_pfn, unsigned long nr_pages,
> void *arg, int (*func)(unsigned long, unsigned long, void *));
>
>+extern int page_is_ram(unsigned long pfn);
>+
> #endif /* __ASSEMBLY__ */
> #endif /* _LINUX_IOPORT_H */
>--- linux-mm.orig/arch/score/mm/init.c 2010-01-10 10:35:38.000000000 +0800
>+++ linux-mm/arch/score/mm/init.c 2010-01-10 10:38:04.000000000 +0800
>@@ -59,7 +59,7 @@ static unsigned long setup_zero_page(voi
> }
>
> #ifndef CONFIG_NEED_MULTIPLE_NODES
>-static int __init page_is_ram(unsigned long pagenr)
>+int page_is_ram(unsigned long pagenr)
> {
> if (pagenr >= min_low_pfn && pagenr < max_low_pfn)
> return 1;
>--- linux-mm.orig/arch/mips/mm/init.c 2010-01-10 10:37:22.000000000 +0800
>+++ linux-mm/arch/mips/mm/init.c 2010-01-10 10:37:26.000000000 +0800
>@@ -298,7 +298,7 @@ void __init fixrange_init(unsigned long
> }
>
> #ifndef CONFIG_NEED_MULTIPLE_NODES
>-static int __init page_is_ram(unsigned long pagenr)
>+int page_is_ram(unsigned long pagenr)
> {
> int i;
>
>
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@xxxxxxxxxxxxxxx
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
--
Live like a child, think like the god.
