Re: [PATCH 2/2] MIPS: add readl/write_be

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Florian Fainelli wrote:
MIPS currently lacks the readl_be and writel_be accessors
which are required by BCM63xx for OHCI and EHCI support.
Let's define them globally for MIPS. This also fixes the
compilation of the bcm63xx defconfig against USB.

Signed-off-by: Florian Fainelli <ffainelli@xxxxxxxxxx>
---
diff --git a/arch/mips/include/asm/io.h b/arch/mips/include/asm/io.h
index 436878e..65cb4e4 100644
--- a/arch/mips/include/asm/io.h
+++ b/arch/mips/include/asm/io.h
@@ -447,6 +447,9 @@ __BUILDIO(q, u64)
 #define readl_relaxed			readl
 #define readq_relaxed			readq
+#define readl_be(addr) __raw_readl((__force unsigned *)addr)
+#define writel_be(val, addr)		__raw_writel(val, (__force unsigned *)addr)
+


Without addressing the need for the patch, as a technical matter, the macro parameters should probably be protected by parenthesis. I.E.:

#define readl_be(addr)			__raw_readl((__force unsigned *)(addr))
#define writel_be(val, addr) __raw_writel((val), (__force unsigned *)(addr))


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux