On Tue, 2009-12-01 at 10:03 -0800, Dmitry Torokhov wrote: > On Tue, Dec 01, 2009 at 03:40:50PM +0000, Ralf Baechle wrote: > > On Tue, Dec 01, 2009 at 07:12:37PM +0800, Wu Zhangin wrote: > > > > > From: Wu Zhangjin <wuzhangjin@xxxxxxxxx> > > > > > > This patch adds Hotkey Driver, which will do relative actions for The > > > hotkey event and report the corresponding input keys to the user-space > > > applications. > > > > This one also should become a platform driver. And is probably a > > candidate for drivers/input/keyboard. > > > > Umm, it still mixes up bunch of stuff not directly related to input. I'd > vote for drivers/platform/mips (since we have a few of kitchen-sink > style drivers for x86-based laptops in drivers/platform/x86). > Hello, Do you mean we go back to drivers/platform/mips/yeeloong_laptop.c? (or split the input stuff into yeeloong_input.c) For considering the next platform support of LynLoong PC and the future other MIPS netbooks/PC(e.g. gdium), perhaps drivers/platform/mips is really the good place to put them in. and benefit from it, we maybe easier to share the functions, variables. of course, the problem about the API modification will also be there: "Experience has shown that drivers for a particular subsystem are best combined in a single menu, in a single directory. Otherwise any changes to subsystem's internal APIs will become a major pain. Which in the end means arch/ is usually the place for drivers that don't fit into any established cathegory." -- Ralf Best Regards, Wu Zhangjin
