On Sun, 2009-11-29 at 23:35 +0100, Rafael J. Wysocki wrote: > On Saturday 28 November 2009, Wu Zhangjin wrote: > > From: Wu Zhangjin <wuzhangjin@xxxxxxxxx> > > > > This patch adds Suspend Driver, which will suspend the YeeLoong Platform > > specific devices. > > > > Signed-off-by: Wu Zhangjin <wuzhangjin@xxxxxxxxx> > > --- > > .../loongson/lemote-2f/yeeloong_laptop/Kconfig | 9 ++ > > .../loongson/lemote-2f/yeeloong_laptop/Makefile | 1 + > > .../loongson/lemote-2f/yeeloong_laptop/suspend.c | 141 ++++++++++++++++++++ > > 3 files changed, 151 insertions(+), 0 deletions(-) > > create mode 100644 arch/mips/loongson/lemote-2f/yeeloong_laptop/suspend.c > > > > diff --git a/arch/mips/loongson/lemote-2f/yeeloong_laptop/Kconfig b/arch/mips/loongson/lemote-2f/yeeloong_laptop/Kconfig > > index c4398ff..49d63c5 100644 > > --- a/arch/mips/loongson/lemote-2f/yeeloong_laptop/Kconfig > > +++ b/arch/mips/loongson/lemote-2f/yeeloong_laptop/Kconfig > > @@ -45,4 +45,13 @@ config YEELOONG_VO > > This option adds Video Output Driver, which provides standard > > interface to turn on/off the video output of LCD, CRT. > > > > +config YEELOONG_SUSPEND > > + tristate "Suspend Driver" > > Why tristate? Allow it to be available as a module. There are lots of platform specific drivers for Lemote-2F family machines, benefit from tristate, the distribution developers can compile them as modules, and then the users can load what they want for their own machines. > > > + depends on YEELOONG_HWMON && YEELOONG_VO > > + select SUSPEND > > I'm not sure if that's going to work. Please make it depend on SUSPEND rather > than select it. Yes, Have replaced "select" by "depend on", thanks! > > > + default y > > + help > > + This option adds Suspend Driver, which will suspend the YeeLoong > > + Platform specific devices. > > + > > endif > > Thanks, > Rafael Thanks & Regards, Wu Zhangjin
