On Sun, 2009-11-29 at 07:29 +0000, Ralf Baechle wrote: > On Sun, Nov 29, 2009 at 01:50:02PM +0800, Wu Zhangjin wrote: > > > On Sat, 2009-11-28 at 21:35 -0800, Dmitry Torokhov wrote: > > > On Sat, Nov 28, 2009 at 09:44:41PM +0800, Wu Zhangjin wrote: > > > > > > > > +config YEELOONG_HOTKEY > > > > + tristate "Hotkey Driver" > > > > + depends on YEELOONG_VO > > > > + select INPUT > > > > > > I think this should be depend, not select. > > > > Hmm, okay, will replace it by depend later ;) > > > > > > > > > + select INPUT_EVDEV > > > > + select SUSPEND > > > > > > Does it break without SUSPEND? > > > > not break, but I just want to select something for users, so, they will > > have no need to care about which extra option is needed. > > We use select extensively on MIPS but select is dangerous and you stepped > into its trap. When SUSPEND is enabled by a user in > kernel/power/Kconfig it can only be choosen if PM is enabled. By > "select SUSPEND" this dependency so now it is possible to have a kernel > where SUSPEND is enabled without PM which won't work. > Get it, thanks for your clarification ;) Regards, Wu Zhangjin
