On Wed, Nov 25, 2009 at 11:57:07PM +0000, Joseph S. Myers wrote: > In the course of updating glibc ports's bits/mman.h files for new MADV_* > definitions, I noticed that arch/mips/include/asm/mman.h does not define > MADV_HWPOISON, although architectures using asm-generic/mman.h get that > definition automatically. Should I take it that this is an oversight and > that a definition of MADV_HWPOISON will be added with value 100, or is > there some reason for it not to be defined for MIPS or for it to have a > different value? Just an omission. Thanks for reporting. I've just checked in below patch. Ralf From: Ralf Baechle <ralf@xxxxxxxxxxxxxx> MIPS: Add missing definition for MADV_HWPOISON. Signed-off-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx> diff --git a/arch/mips/include/asm/mman.h b/arch/mips/include/asm/mman.h index a2250f3..c892bfb 100644 --- a/arch/mips/include/asm/mman.h +++ b/arch/mips/include/asm/mman.h @@ -75,6 +75,7 @@ #define MADV_MERGEABLE 12 /* KSM may merge identical pages */ #define MADV_UNMERGEABLE 13 /* KSM may not merge identical pages */ +#define MADV_HWPOISON 100 /* poison a page for testing */ /* compatibility flags */ #define MAP_FILE 0
