Re: [PATCH v7 04/17] tracing: add static function tracer support for MIPS

[David Daney <ddaney@xxxxxxxxxxxxxxxxxx>]

Wu Zhangjin wrote:

>  
> +ifndef CONFIG_FUNCTION_TRACER
>  cflags-y := -ffunction-sections
> +else
> +cflags-y := -mlong-calls
> +endif
>  cflags-y += $(call cc-option, -mno-check-zero-division)
>  

That doesn't make sense to me.  Modules are already compiled with 
-mlong-calls.  The only time you would need the entire kernel compiled 
with -mlong-calls is if the tracer were in a module.  The logic here 
doesn't seem to reflect that.

David Daney