Re: [PATCH v7 17/17] tracing: make function graph tracer work with -mmcount-ra-address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Wu Zhangjin wrote:
[...]
+	cflags-y += $(call cc-option, -mmcount-ra-address)
[...]
+#if (__GNUC__ <= 4 && __GNUC_MINOR__ < 5)



Sprinkling the code with these #if clauses is ugly and prone to breakage I think.

The Makefile part is testing for the same feature.

We do a very similar thing with -msym32, and KBUILD_SYM32. Perhaps you could rework this patch in a similar manner and test for KBUILD_MCOUNT_RA_ADDRESS instead of the '(__GNUC__ <= 4 && __GNUC_MINOR__ < 5)'

David Daney


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux