Re: [PATCH] Make MIPS dynamic clocksource/clockevent clock code generic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Linus Walleij wrote:
2009/10/20 David Daney <ddaney@xxxxxxxxxxxxxxxxxx>:

Please do not make that functions inline. They are too large and there
is no benefit of inlining them.
If that is the case, then perhaps they should not be defined in a header
file.

Of course not. There are apropriate places to put them, but as stated
I think the use as it is today warrants having them inlined.


I wasn't trying to imply that they shouldn't be inlined, only that if you choose (as you did) to define them in a header file, that they *should* be inline.

David Daney


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux